I've not heard anyone advise others to save for about 17 years.
People's grandparents used to do I think.
But mine have all been dead since about that time.
For sure the idea of saving is not a bad one, and so for sure, the criticism of savings relates to the ongoing debasement of cash - and frequently people are still mislead about whether saving is a good thing or not - and yeah a lot of the debasement of the cash does encourage poor people to not save, since the cash is not holding its value.. and so if they do not have any place to put their money in order to hold value they will spend their cash more quickly... and sometimes their consumptive goods will hold value more than the cash would have had done.
There do seem to be quite a few investments that have come available to normies, including bitcoin, yet normies still might not appreciate the value of investing and/or savings because they have been so perverted over the past several years... including the largely disappearance of the interest rate... and yeah, sometimes the interest rate that banks provide does not even keep up with the rate at which the money is debased (or the rate at which prices go up, which also varies from product to product).
Banks always have a win-win scenario for themselves. Saving money in Banks looks lucrative but the profit given by Banks is proportional to inflation rate. So if you are saving money in Banks (say 5 to 10 years) then you get profit which will be neutralised by inflation rate.
I want to buy a new car and for that I am saving money but whenever I am getting close to value of car then price jumps to new higher value. That's why I gave up idea of buying new car and gave up the concept of saving money to buy new car.
To me you must have some cash in savings that is readily available to counter your necessary and emergency needs, money over that must be invested somewhere.