Post
Topic
Board Development & Technical Discussion
Re: Feedback for BTC mini key generator
by
ABCbits
on 19/08/2024, 10:39:22 UTC
But we really want some hardcore feedback.

Most member who visit this board aren't programmer or Bitcoin developer, so don't expect hardcore feedback. But here's my amateur feedback.
1. What would happen if there's no audio input on the device? Would the code throw error or return weird data?
2. Consider adding tests to your code.
3. I think using audio input, os.urandom and secrets should be secure enough.