Do you mean better or which is more profitable? To me, it depends on which market you have more knowledge, practice and experience on. For crypto, I just buy my coins and hodl for long term profits. Cryptocurrency are very volatile and trading them requires enough knowledge on different things like the total market volumes, the rate at which investors are interested in such coins so you don't end up trading the wrong coin. As for forex though they literally are same thing since you still have to understand the market pair which you which to trade and it's past movement patterns. Forex is more profitable in the short term and with good knowledge on how to predict the market you can make good profits compared to that of crypto market.