Although the OP is asking whether he taught his friend good, and we all agree that he could've done it better, let's prevent the tree from letting us see the forest.

The guidelines he gave to him are correct, and although missed some crucial points related to security, newbies don't usually start holding a great portfolio, but enter slowly in the rabbit hole, so for a few satoshis it is ok.

He encouraged him to go from zero to something, to take the first step toward personal adoption. For more detailed knowledge, his friend still has a long way to go; a path that one has to walk oneself.