If actually Bitcoin is the subject matter then buying and selling within the period of one year apparently has nothing to be called anything related to investment but trading because one year is too short for your investment to experience the power of compounded value of your investment, a cycle which is four years would have been better to be described as a short term investment in my perception while four to 10 years or more can be called a long term investment.
Okay I have learned something today, atleast you have given a timeline for short and long term Bitcoin investment. Most people who target to buy during the Bitcoin halving are short-term traders, and that's a very wrong investment approach.