I’m using Trezor the first version to hold my altcoins but in terms of convenience I preferred ledger because they offer much user friendly UI on their ledger live app.
What I just don’t like about ledger is their recent recovery feature which means they have access to our hardware wallet.
Ledger is user-friendly, but they already had so many vulnerabilities in the past, exploits, and any attacks.
It also does not have open-source code, so we don't know whether the program itself is vulnerable to attacks or not.
If I remember correctly, they do have a cloud backup, and seed phrase generation is compromised due to autocorrect, which is connected to Google.
So, if you are going to hold a large amount of coins, I don't recommend using Ledger. Trezor is much safer than this.