i've seen a few different bitcoin hardware wallets they look sweet!
One of the main concerns when I started looking into it is that a hardware wallet for general use really needs to have a display and a "confirm transaction" key otherwise it's vulnerable to certain kinds of attack.