Post
Topic
Board Announcements (Altcoins)
Re: [ANN][DT] DarkToken - NIST5 - PoW/PoS
by
gjhiggins
on 28/09/2014, 04:33:44 UTC
copy from SSD?
only change algo

Surely not. It's a fairly direct copy of Icebergcoin, including the clumsy cut'n'paste ...

https://github.com/darktoken/darktoken/blob/master/src/test/key_tests.cpp#L41


    for (int nCompressed=0; nCompressed<2; nCompressed++)
    {
        bool fCompressed = nCompressed == 1;
        printf("  * %s:\n", fCompressed ? "compressed" : "uncompressed");
        CIcebergcoinSecret bsecret;

Hey, thanks for pointing this out. We have fixed it and commited the fix to our github (https://github.com/darktoken/darktoken).
You seem a bit beleaguered. Do you need some help managing this? The codebase remains unchanged in this above respect: https://github.com/darktoken/darktoken/blob/master/src/test/key_tests.cpp#L41

The last activity was a 652-file commit which did nothing other than improperly set the executable filemode bit on a raft of source files and add a superfluous IDE config file as a final flourish. It strongly suggests either i) a lack of familiarity with the tools or i) the result of the dev's cat walking on the keyboard.

Quote
And btw, we choose Icebergcoin's code to be our base code because, after some weeks of testing it proved itself to be by far, the stablest code we encountered.
Then, given there's 100 BTC of other folks' money on the table, surely it's worth cleaning up the code and removing the inappropriate substitutions? Sort of like this: https://github.com/gjhiggins/darktoken

(I'm a little disturbed at what seems to be an increasing tendency to to favour publishing developed binaries, particularly Windows binaries, where the enhancements are not committed to the open source repository, obliging users to adopt what is effectively proprietary code. I note that the exchange tab in the screenshots is only available in the published binaries. To ensure that Linux users don't get left out, I added an exchange trading tab, filched from some development going on in icebergcoin's repos. It's hard-coded to use just Bittrex' JSON API but it does seem to hold promise. I was able successfully to add a Bittrex API tag and key which then enabled the Buy/Sell/History tabs. I'll leave the acid test to someone who actually holds DT.)


Cheers

Graham