Post
Topic
Board Announcements (Altcoins)
Re: [BBR] Boolberry: Privacy and Security - Guaranteed[Bittrex/Poloniex]GPU Released
by
otila
on 07/10/2014, 21:04:20 UTC
            cipherids = (password % NUM_CIPHERS);  // choose one of 18 ciphers
8<
The following are the ciphers:
    "aes","blowfish","xtea","rc5","rc6","saferp","twofish","safer_k64","safer_sk64","safer_k128",
    "safer_sk128","rc2","des3","cast5","noekeon","skipjack","khazad","anubis","rijndael"

But why?

Why not just AES? And do you realize how much RC2 sucks, and SAFER-(S)K64 has 64 bit key size?
does having different ciphers hurt? it allows short (user rememberable passwords to "salt" things)
unless any of these ciphers have been cracked, using them means that all the ciphers would need to be cracked.
using just AES means if AES is cracked then all the files are cracked.

so is having a sucky RC2 and a weak 64 bit layer in addition to AES worse than just AES?

cipherids = (password % NUM_CIPHERS);
cipherids and password are not used inside the loop, who knows what it's supposed to do.
And how do you calculate modulus of char*? password does not change, so cipherids is the same, too.

What are you doing, encrypting the same plaintext 18 times with different ciphers?
Besides bloating the code, it would be over 100 times slower than just using AES (+AES-NI), and think if someone wants to reimplement this part of the code using Haskell or something Tongue