Post
Topic
Board Announcements (Altcoins)
Re: Official Anoncoin chat thread (including history)
by
Gnosis-
on 29/10/2014, 07:28:33 UTC
Thanks Gnosis for quick answer on mine previous question.Now I found something much more serious.In Bitcoin before v0.8.6 wallet.cpp code had one serious bug which allows relaying of invalid transactions.Error in code allowed insertion of empty transactions into vtxPrev which nasty consequence was that nodes whose transmitting such transactions were banned - causing shutdown parts of network, problems in nodes communications and acception of transactions.This bug was never fixed in Anoncoin wallet.cpp:

Bug is on wallet.cpp Line 850 of anoncoin code - if (!tx.IsCoinBase())  should be if (!tx.IsCoinBase() && !tx.vin.empty())

@thunderjet - Excellent find!  Spent allot of time in that RelayWalletTransaction(), convinced that was where the problem must be @.  My initial reaction here is that you've nailed it.  My experience is primarily with the 0.9.2+ codebase & there is significant differences between the two there, did not know that about 0.8.6.  We'll have to see what Gnosis thinks, but I'm really happy you pointed this out!

This is encouraging! I'll take a closer look when I wake up in ~9 hours.