Quote from: dooglus on October 26, 2015, 06:09:28 PM

Quote from: ClamBaker.Club on October 22, 2015, 10:27:53 AM

I was fortunate enough to have Just-Dice.com owner dooglus give me a hand in auditing and bug fixing on the site!
Everything should be functioning as normal again. We had to rebuild the database as well as fix a few scripts.

I did help out. The scripts being used were really pretty bad. I fixed a few of the most obvious bugs but not all of them. I personally wouldn't be using these scripts on a live site. They feel like an accident waiting to happen.

One bug that I didn't fix is in the way the script determines which address to pay out to. It looks at the first input of the deposit transaction, finds which transaction created that output, and the uses the address of either the 1st or 2nd output of that transaction as the address to repay. There's no comment to explain why such a strange strategy is used, but it will often result in the wrong person being paid out.

See http://i.imgur.com/A0BvC0h.png and http://clamsight.com/tx/c38a5be7810f6ef6ac74c08d263198d100a779ddc5d963a56ddb28bda78c5815 for a couple of examples.

Why isn't he just sending back to the first input (Labeled output in your image). The xDkh address in your image. That is still going to have problems if sent from JD but
he does have a mess of warnings... Also you should control all of the address your sending from...

Since I don't know what he's actually going to use to send back, I just had to make some assumptions... Not sure if I even understand it correctly.