Quote from: LiteCoinGuy on January 02, 2016, 06:38:48 PM

i hope this thread will not waste too much dev-time for nothing in the end. PR is necessary but time is limited too.

We shouldn't assume the Core developers or anyone else is immune from review and I believe there is always something to learn my looking over other implementations. I think it is both extremely healthy for there to be multiple implementations in our ecosystem with different project maintainers and for them to both collaborate and review each others work. We should support Core, BU , libbitcoin , and others with testing.

To add to the discussion Gavin represents a qualified outside developer that conducted a very brief review of the code and this was his response-

https://bitco.in/forum/threads/i-really-want-to-like-bitcoin-unlimited.684/

Quote from: Gavin

I love the idea of Bitcoin Unlimited, but after doing a quick code review I just can't recommend that people run it -- there are too many "bad code smells."

Examples:

https://github.com/gandrewstone/BitcoinUnlimited/commit/9b05e2e9f7eb4d8e847c57ae06d8bd34b1f03552

... which is a commit with title 'wip' (work in progress). Un-descriptive commit titles/messages are bad... as is committing a work in progress before it is finished.

Or commits which comment out code, which is, in general, bad practice (if code isn't needed it should be removed-- your version control system keeps old code if you change your mind and decide later if you need it).

The most critical commit:
https://github.com/gandrewstone/BitcoinUnlimited/commit/b126b10a1675c52acd0d7df857afe8057cfb6fb3

... doesn't seem to have any unit or regression tests. I would expect the commit message to at least say something about how the code was tested.

Andrew, do you have experience leading an open source software project? Ideally Bitcoin Unlimited would be lead by somebody who has a track record in projects that produce very high quality, reliable code (on time and under budget

) (and no, I'm not volunteering....)

More review of both core and BU is recommended and encouraged.