Quote from: etherauction on April 03, 2016, 05:56:36 PM

Quote from: etherauction on April 03, 2016, 05:22:43 PM

Edit: The code seems to act as described, albeit it's rather hairy, inefficient, and poorly written.

Well I'm still learning here Roll Eyes

If you want a quick codereview:

- There's no need for the struct, since it's only got one element in it.
- You don't actually need to store anything other than the most recent address. There's no need for an array here.
- CurrentTime and current_Balance don't need to be storage variables.
- 'now' doesn't change during the execution of the transaction, so there's no need to store it in a variable at all.
- You never read from 'current_Balance', and it's always equal to this.balance, so there's no need to have that variable, either.
- If you declare the relevant variables public, you don't need the accessor functions CT()/PT()/bal().

All that said, it seems conceptually sound, which is a step up over a lot of contracts in this forum. Wink

[/quote]

Nice, thanks for the review man !!
I'll make sure to take those into account if another idea pops up Wink

(I'll use the accessor for the website but I'll first make a quick one without any variable)

Yep, even if I like all these betting game, ponzi, etc. I think that the scams are a real plague, I've already lost more than 25 ETH to piggybank, castle, etc. This is stupid and I'm not proud of it but it somehow feels good to confess I was stupid (even my wife doesn't know about it Cheesy

)