Quote from: bitfreak! on January 02, 2017, 10:45:46 AM

Quote from: pallas on January 02, 2017, 08:34:25 AM

Since whis was fixed soon after XCN release, it may be trivial to backport.
Could you point me to the commit on the bitcoin git? I will have a look.

I have previously tried looking for a specific commit which fixed the issue but couldn't seem to find one. I think the fix may have been included with some larger patch, I'm not really sure. I found several bug reports about random wallet corruption, such as this one, which were made around the start of 2014 and have the same error codes, however it seems they were closed without referencing a commit which solved the issue. I recall our core dev being stumped about the wallet corruption because he didn't change anything that could have caused it, so I'm fairly certain it is a bug inherited from Bitcoin.

I never experienced the wallet corruption issue in months, so I'm unlikely to be able to fix it.
Can someone who recently experienced it share some more information? debug.log snip?

Quote from: bitfreak! on January 02, 2017, 10:45:46 AM

Quote from: pallas on January 02, 2017, 08:34:25 AM

This might be a bit more complex: do you have an idea what kind of work is needed for this?

Yes it wont be as simple as copying the Bitcoin implementation because we have the whole account tree thing. I have a rough idea as to what would be required, the hard part will be adapting all the changes Bitcoin has undergone in the last few years, much of the code has been overhauled to work in a very different way to how it worked when Cryptonite was forked from it, but many of those changes are necessary to make things like the parallel block downloading work properly.

Maybe we can make a quick workaround: I've seen many coins hang on initial sync, then work fine after the wallet is just restarted. Maybe we could put a timeout on the connection, so it changes peer when more are known, maybe choosing the one with higher block height. What do you think?