Quote from: joblo on December 19, 2017, 05:34:30 PM

Quote from: 4ward on December 19, 2017, 04:15:51 PM

Quote from: joblo on December 19, 2017, 02:46:36 AM

Quote from: 4ward on December 18, 2017, 07:17:38 AM

One thing I couldn't resolve is that neoscrypt always fails to run (same in My9bot's version)

I can look into this now.

-DNOASM didn't solve the issue, it still fails.

But you are right, this algo is definitely not the best performer, so I don't know if its worth investing much time in it

I found a potential problem that could cause data misalignment.

In algo/neoscrypt.c line 56:

Code:

#if (WINDOWS)
/* sizeof(unsigned long) = 4 for MinGW64 */
typedef unsigned long long ulong;
#else
typedef unsigned long ulong;
#endif
typedef unsigned int uint;

Further down in the code some data defined as uint is accessed as ulong which has stricter
alignment requirements if defined as long long. If the condition is removed and ulong is the
same as uint it shouldn't crash.

I found no other compilation divergence and alignment bugs can slip through unnoticed for
a time. The trigger seems to be the different compile environment.

Can you test to confirm?

tried this

Code:

// #if (WINDOWS)
/* sizeof(unsigned long) = 4 for MinGW64 */
// typedef unsigned long long ulong;
// #else
typedef unsigned long ulong;
// #endif
typedef unsigned int uint;

same problem, unless I'm doing it wrong )