Quote from: Neisklar on August 30, 2013, 05:40:13 AM

Quote from: zvs on August 30, 2013, 05:18:28 AM

0% fee, 0% donation (does that address even go to someone?)....

Yep, it's one of mine.

Please be sure to read the comments in the source p2pool/data.py (i think around line 50)
...
wait, i had that somewhere written already, lets post that, some important thing is marked bold

Quote

That address is somewhat special, in one of the posts in the Quarkcoin thead here i mentioned that stuff already.
I noted my (hopeful correct) findings of it in the source: p2pool/data.py:

starting around line 54

Code:

### Neisklar:
### It took a while to figure it out:
### This is a UNCOMPRESSED public key surrounded by 4104 ... ac
### Important is the (clever or not?) way it is used:
### ALL shares in the p2pools chains depend on that value, means if you would like to join a p2pool network with your own node with this value changed
### would invalidate ALL shares. Means your own node would see all shares from the other nodes as invalid, and the p2pool network with the other value would see
### all your shares as invalid. Of course if you run a standalone node as pool, this isn't a problem, as long as you DO NOT change this value after your local node
### has produced some shares without deleting the share database /data/
### Also important: It must be so long, i tried it with newer Script wich includes only the pubkey hash (76a914...(pubkey_hash)...88ac), this will break the pool.

DONATION_SCRIPT = '4104ebc79bbfd3901db557108d9e8815bf13ff2c170a63ff1546a6e6d99ef90004f78b94753ba550e9be681cde100ed84a439103e03290f1d34cf4d7e1c3535d2a93ac'.decode('hex')

So thats an address of me ( Wink), if someone wants to do it (i don't know why) he could run the node with --donate-to-author or somewhat to give that address some share. That param was in the original code even defaulted to 1 percent, i did zero it hopefully in the source.

Another important thing is when you look at the stats page under rewards of my pool you see the following:
Qe91rA2W8fQ3b19cknuVuxVhxgqdbkvL4m 0.0002
EVEN as donations to author are set to 0.
This is all what is left after payoutprocessing which has some rounding in it. So with current reward of 1024 thats not so much, but when the reward gows down, that will be much more.

So if you want to change that, no problem, you need an uncompressed public key (should be 65 bytes long) and put them between the 4104 and the ac. (It may also that that uncompressed pubkey is already prefixed with 04, then don't double the 04).

If we later establish a p2pool network, then this value MUST be the same on all nodes, if not it will not work (clever or not of the original p2pool author?).
If the time arrives, lets discuss that together with Max the developer of Quark and then maybe use as Network-Donantion address an address of Max, or some other address which is used for special stuff.

Oh, I don't mind, I probably would have put it at 0.2% or so, same as I have the bitcoin pool at..

On another note, the person mining as 'quarkcoinrpc' on my p2pool, that all goes to me... you have to use your address as username.

PM me and I can send you what you got... if you can prove who you are. Cry

I did a capture of the IP addresses & the earliest time you got a share, so it narrows the IP range down quite a bit, but you'd have to give me your IP I think for proof (ed: unless there's a better way I can't think of atm... but I can narrow it down to about a half dozen IPs)