Quote from: BitFanatic on November 10, 2013, 12:29:48 PM

So this random object value is used for ALL of the wallets when creating them in bulk. Surely the secureRandom should be recreated for each wallet?

because reusing it doesn't decrease the entropy of resulting wallets.

Quote from: neutrinox on November 10, 2013, 12:48:31 PM

My biggest concern at bitaddress.org is the use of external javascript files. This gives the host of those files the possibility to execute any javascript on the page. They could easily insert a function that sends the private keys to a third party website. If that's done only 1 of 10 times, it's hard to get caught.

it does? the page is a single html file with no other dependencies.

Quote from: DobZombie on November 10, 2013, 04:01:12 PM

Quote from: BitFanatic on November 10, 2013, 01:58:37 PM

Yeah - all I wanted to do was modify the code a bit to add some of my own extra randomness to it for my sanity... But this has put me off completely now! I just want to create a really secure paper wallet where I don't need to trust somebody... Any ideas?

why don't you multiple the output random number by the current time code. that'll add an extra layer of entropy

better idea: xor the output random number by the current time code. multiplying will add a bias toward bigger numbers.