Quote from: trout on November 16, 2013, 12:46:35 PM

Luke, can you describe more clearly what the patch does?
in particular:
- one reuse of any given address per block, or one address reuse per block?
- does it concern only inputs, outputs, or both? for example, an address
that has several inputs and tries to spend them all is deprioritized or not ?

This first patch just rejects from your memorypool any transaction which:

Sends to a scriptPubKey which is already sent to (output) by another transaction in the memorypool.
Sends to a scriptPubKey which is already being used to redeem a coin (input) by another transaction in the memorypool.
Sends to the same scriptPubKey in two different outputs, within the same transaction.
Uses a scriptPubKey to redeem a coin (input) which has already been used to redeem a coin (input) by another transaction in the memorypool.

Quote from: Strophon on November 16, 2013, 01:48:19 PM

And then there's Blockchain.info. Did you know Blockchain.info wallets reuse addresses by default unless you create new ones?

Any software which reuses addresses by default is broken.
I am okay with forcing incompetent* software developers to fix their software.

* Sorry, they should really know better.

Quote from: Carlton Banks on November 16, 2013, 07:50:41 PM

I assume this cannot affect the prioritisation of the Coinbase transaction that constitutes p2pool miner's reward payments? Can you clarify this?

This will not affect any generation transactions, nor any miners who choose not to use it.