Post
Topic
Board CPU/GPU Bitcoin mining hardware
Re: DiabloMiner GPU Miner (Long Poll, BFI_INT, async networking, multipool)
by
DiabloD3
on 17/07/2011, 02:04:39 UTC
Eh, too much trouble. I see you already fixed the exec java bit for Linux. For the others, replace your !"".equals(String) calls (8 instances) with a call to a method like this:

Code:
protected boolean hasLength(String str) {
    return str != null && str.length() > 0;
}

Your splitting on commas for pool support breaks values with commas in them (e.g., passwords).

Around 831, there should be a null check on getWorkParser.

Java coders prefer checking against "" instead of checking length for some reason. Almost all the places I check also check for null as well.

And why around 831? At no point can that be null.