Quote from: DiabloD3 on July 17, 2011, 02:04:39 AM

Quote from: ellipsis on July 16, 2011, 10:03:42 PM

Eh, too much trouble. I see you already fixed the exec java bit for Linux. For the others, replace your !"".equals(String) calls (8 instances) with a call to a method like this:

Code:

protected boolean hasLength(String str) {
return str != null && str.length() > 0;
}

Your splitting on commas for pool support breaks values with commas in them (e.g., passwords).

Around 831, there should be a null check on getWorkParser.

Java coders prefer checking against "" instead of checking length for some reason. Almost all the places I check also check for null as well.

Maybe retarded Java coders. !"".equals(null) evaluates as true (!false). You intend for it to return false, as in this case:

Code:

if(!"".equals(url.getUserInfo())) {
String[] userPassSplit = url.getUserInfo().split(":");

If url.getUserInfo() returns null, you will proceed into the conditional block and dereference a null.

Code:

if(hasLength(url.getUserInfo())) {
String[] userPassSplit = url.getUserInfo().split(":");

hasLength will return false, and skip the block. Hurrah.

Quote from: DiabloD3 on July 17, 2011, 02:04:39 AM

And why around 831? At no point can that be null.

Really? What if you get an InterruptedException before you return from getWorkQueue.take()?

Lesson complete.