Quote from: wyager on December 26, 2013, 10:56:02 PM

Thanks. Some small suggested changes:

1. Specify endianness of the each field. In your examples, the prefix is big-endian, but the date is little-endian. I recommend big-endian for all fields (since in many scripting languages, it's easier to go from an integer to a big-endian string than a little-endian string).

Bitcoin is little endian, with exception of big int math. BIP 38 is also little endian, with exception of prefix. I've clarified that the date field is little endian.

Quote from: wyager on December 26, 2013, 10:56:02 PM

2. Recommend that client implementers check the blockchain, say, a day before the beginning of the "recorded" date to account for slightly incorrect date calculations. Either that or specify that the date code should be based on date minus one day.

Done.

Quote from: wyager on December 26, 2013, 10:56:02 PM

All test vectors passed in my implementation!

Yay!

Quote from: wyager on December 26, 2013, 10:56:02 PM

Please specify that unicode passwords (like the chinese one you gave in the test vectors) should be converted to UTF-8.

Done.