Quote from: qbitx on March 13, 2014, 12:09:50 AM

Quote from: feeleep on March 11, 2014, 09:33:54 AM

@phm

I was investigating rejected share ration for quark based coins and noticed that you may have a mistake in the code:

https://github.com/prettyhatemachine/sph-sgminer/blob/master/quarkcoin.c#L144

for quarks it should be:

Code:

static const uint32_t diff1targ = 0x00000000ffff;

instead of:

Code:

static const uint32_t diff1targ = 0x0000ffff;

please consider this

feeleep

This comment makes no sense!
Both of those lines do literally the exact same thing. The first one might actually make some compilers mad for setting a uint32_t (32 bits!) to a value that appears to be padded out to 48 bits in length (why?!)
In C, setting "a = 0xFFFF", "a = 0x00FFFF", "a = 65535", "a = 0x0000FFFF", all have the same EXACT RESULT. The only difference is readability.

Please explain why you would ever use the first statement.

indeed it doesn't make sense but I said I haven't touched c++ for 20 years Wink