Post
Topic
Board Development & Technical Discussion
Re: Feedback for BTC mini key generator
by
Quickseller
on 19/08/2024, 13:39:32 UTC
But we really want some hardcore feedback.

Most member who visit this board aren't programmer or Bitcoin developer, so don't expect hardcore feedback. But here's my amateur feedback.
1. What would happen if there's no audio input on the device? Would the code throw error or return weird data?
If the audio cannot be detected, or if there is no audio device, an exception will be raised.

It appears the script is intended to use the user's audio input as a means of 'randomness'

Code:
#audio_randomness.py
    if frame_count < min_frames:
        raise ValueError("Insufficient audio data captured. Try increasing the duration or ensuring the microphone is working properly.")

#...
 # Check if audio data is silent
    audio_array = np.frombuffer(audio_data, dtype=np.int16)
    if np.max(np.abs(audio_array)) < silence_threshold:
        raise ValueError("Captured audio appears to be silent. Please check the microphone volume and try again.")