Quote from: tacotime on April 30, 2014, 03:47:39 PM

Quote from: thankful_for_today on April 30, 2014, 03:40:28 PM

Quote from: tacotime on April 30, 2014, 03:37:47 PM

Quote from: thankful_for_today on April 30, 2014, 03:15:08 PM

Bug is fixed. Please update from git.

I'm going to ask Takotime to build binaries for Windows.

Your fix is wrong. There is no need to disable all error checking. Simply commenting out the line works fine, I just tested it.

https://github.com/monero-project/bitmonero/commit/cf8fe2867654f0061a17ca4780e736a170a8f87b

In this case the rest of transation can't be parsed by wallet. This means that wallet has to stop parsing this tx. The proper fix will be issued later after talking to Amphibian who created this tx.

There are no issues so far with implementing the fix as in my commit, but yes, this is improper error handling

It further parses after without error

It doesn't fail in this case but there is no reason to parse it futher because there is no way to understand it. Your version of wallet that continues to parse unknown data is vulnerable to some possible attacks.