Post
Topic
Board Announcements (Altcoins)
Re: Execoin: | Electrum |Android & Lite wallets | Fast | ASIC-proof | Full-time devs
by
fukukami
on 18/06/2014, 15:31:52 UTC
Thanks for stealing our hard work again without giving credits to Wozz and Paybee.


https://github.com/paybee/electrum-vert

This is where all the hard work was done but you forked the ltc electrum and just copy pasted it over so no one sees its from the electrum-vert github, nice work.
Wozz did the main work on this, writing all the KGW  stuff in python etc.



https[Suspicious link removed]/blob/master/lib/blockchain.py

Code:
try:
    from vtc_scrypt import getPoWHash
except ImportError:
    print_msg("Warning: vtc_scrypt not available, using fallback")
    from scrypt import scrypt_2048_1_1_80 as getPoWHash


https://github.com/paybee/electrum-vert/blob/master/lib/blockchain.py

Code:
try:
    from vtc_scrypt import getPoWHash
except ImportError:
    print_msg("Warning: vtc_scrypt not available, using fallback")
    from scrypt import scrypt_N_1_1_80 as getPoWHash


funny that you didn't even make a working scrypt execoin module for python, so this electrum will stop working when execoin nfactor changes...

PS: The version you use has still bugs left thats why it wasnt really published.
PS2: We are all sooo impressed by the hard working execoin dev.......

Dear othe!

I was not going to steal anyone's credit and hard work. That was just an accidental error during rebase. Thing is, commits in electrum-vert are a bit messy to my liking, so I've decided to recommit only KGW modifications by wozz.
So I'm really sorry I made this to wozz, and I greatly apologize. This is the fix in a repo for that (commit 06612afd5e246628095b518fc9dd83ee21ad2f07)
And as far as I can see out of commit history, paybee did nothing in KGW code except mergin PRs (https://github.com/paybee/electrum-vert/pull/1). If I'm wrong, please correct me, so I should be able to credit him too.

Take a note that my code is based on pooler's electrum-ltc and not on electrum-vert, as you can clearly see here at commit c7dcf10109a6160f9692c9eb264e158a8456267d.
Also, I've modified pooler's scrypt to add support of current N in execoin. Function is called scrypt_2048_1_1_80 that will be changed with another function soon, and will be aware of N change schedule, but in the meantime I use vtc_scrypt (it's nothing wrong with using open source pypi package, rigth?), that will also be changed to exe_scrypt soon, so current implementation will be left only as a fallback.

Anyway, there is at least a year till N in execoin will change, and creating of new function is quick, so don't worry about that.
P.S. Electum-vert has not been updated since May 26. Hasn't it been published yet because of bugs? I bet they still have confirmations bug, that is magically fixed in me code.

I've fixed some of the bugs discovered during testing phase, if you would find more in electrum-exe - your bug reports will be greatly appreciated.