Quote from: helgabutters on July 18, 2014, 10:15:03 PM

Sorry for the delay, works been rather busy the past few days so I haven't been able to put in as much time as I'd like. Also, could you give me some insight on which ones I've submitted that are definitely not bugs and a few that you aren't sure of? I'm just trying to gauge what exactly you want and what I can safely not worry about finding/reporting.

Thanks for posting some more bugs to fix. I've started going through them. At least one (#2) isn't a bug because you're passing in a Base58 value, while the error message is counting the number of bytes in the decoded value. Subtle, I know, but it doesn't really count as a bug.

In the meantime, I'll see what I can get into 0.92. Gonna go pester Alan.

EDIT: Also, as I'm going through these, I'm noticing that some aren't actual bugs. For example, #3 isn't a bug. You need to supply a block hash. So, the following would be valid. (I just tested it.)

Code:

python armoryd.py --testnet getblock 00000000000072da6566808cce7e50c0b4f26fd56993a2a22d8d26e7cc23bad8

Use the following to see what the parameters should be. You can also poke around the source to see some examples.

Code:

python armoryd.py --testnet help

EDIT 2: Regarding #5, this is a bug, but not in the sense that you may think. One thing I forgot to point out in the help text is that the message needs to be passed in with quotation marks so as to avoid tripping up the command line argument detector. I've included an example of what's valid (other than the obvious nonsense).

Code:

python armoryd.py verifysignature \"-----BEGIN BITCOIN SIGNED MESSAGE-----$'\n'Comment: Hello.$'\n'-----BEGIN BITCOIN SIGNATURE-----$'\n'$'\n'junkjunkjunk$'\n'-----END BITCOIN SIGNATURE-----\"

That being said, it turns out that the unit test we wrote didn't take into account the fact that, on the command line, the spaces would cause the sig to be split into multiple pieces. I fixed that.

EDIT 3: #7 is also not a bug. The formatting isn't quite right. The following shows a format that will work. It's basically the same as the one from #5 with the exception that quotation marks aren't required (and will, in fact, mess things up, although I might slip in some code to handle that particular case.)

Code:

python armoryd.py --testnet signasciitransaction =====TXSIGCOLLECT-GynG9f37======================================$'\n'AQAAAAsRCQcAAAAAAf18AQEAAAALEQkHchUHvHxM29fPeY02InKy5ZQeYZ8vMA9G$'\n'rJVpM8tCGBEAAAAA/QEBAQAAAAEhOzQQbizqkYkkOvs8sxROO1j198R/ls8zebRC$'\n'TgGNagMAAACMSTBGAiEA5nWwoKcAU7g3dhs/5dkq6eaw+yY7T+uJiqKbnmjwkjAC$'\n'IQCARNrs4jaNx5iNFPyObj05olSK710suLl+YbfKe8ihUgFBBM3zuTqCoy/uKAh0$'\n'Kgn5LeWNYpMv/WJvqUsJYT2+/QtuG73EQhswCxN7aqyOaOF8EHN7mLUT93p9G0st$'\n'eWtEUof/////AlA/R9wVAAAAGXapFCOOhZJjttO/Z1siFJighsAM3huMiKwAypo7$'\n'AAAAABepFEsgPEt7f4VFiKFCrGqixxSWvpZVhwAAAAAAAAD/////AUEEYjJpOVJc$'\n'aXeB3CgM2Apdk/GpLtSA4wrfvuvhsbweFhs/BqIi3MpiugRcdTbTox3iVUhCpYon$'\n'BrmWu9/jvMRqjwAAAjQBAAAACxEJBxl2qRQApYwGgX3k4qNc5Y6XjJCDxNbZd4is$'\n'UF5R1hUAAAAAAAROT05FAAAANAEAAAALEQkHGXapFENn/3Vq4y59O99BpXN6HZTH$'\n'Zbh8iKwA4fUFAAAAAAAABE5PTkUAAAA=$'\n'================================================================

EDIT 4: (Final edit, I hope!) Hmmm. I'm not able to reproduce #8. Works for me. Sanity check: Are you using a testnet wallet in that particular example? If you are, PM me and we'll discuss what's going on.

With that said, everything other than #4 and #8 has been handled one way or another. I'll get the rest tomorrow.