Quote from: windpath on August 11, 2014, 05:32:30 PM

Quote from: Solcoin Project on August 11, 2014, 05:10:02 PM

I'm running a p2pool for an altcoin, and I'm seeing odd payouts that don't reflect the 1% fee configured. More like 0.2-0.5%. Here is a list of transactions going to the wallet of the daemon the pool is connected to: http://explorer.solcoin.net/address/8SLHAh8LukapttooKzdWocZ41tG5hne1UQ

Each block has a value of 1772 coins currently, so each transaction per found block should be around 17 coins, no? What's causing this?

The fee is 1% of valid shares, not 1% of total BTC mined.

So if a miner submits 100 shares, the expected result is the miner receives 99 and the node address receives 1.

Code in work.py line 161:

Code:

if random.uniform(0, 100) < self.worker_fee:
pubkey_hash = self.my_pubkey_hash
else:
try:
pubkey_hash = bitcoin_data.address_to_pubkey_hash(user, self.node.net.PARENT)
except: # XXX blah
pubkey_hash = self.my_pubkey_hash

return user, pubkey_hash, desired_share_target, desired_pseudoshare_target

Ah, that explains it I guess. Thanks!