Post
Topic
Board Services
Merits 2 from 1 user
Re: [PAID TESTERS NEEDED] Zenland Escrow Contract | Custom Agents | Up to $20 (open)
by
Diornov
on 11/01/2024, 12:11:15 UTC
⭐ Merited by libert19 (2)
    Hello. I want to personally thank everyone who completed the review with our new custom agent feature.

    Also, I wanted to let you know that as soon as we conclude our beta test campaign, we will launch the official Zenland Custom Agents of Bitcointalk Thread.


    - as soon as I resolved dispute, it disappeared from my profile. No where to be found.

    When I clicked on send button the contract automatically vanished

    -The contract is no longer visible at all once the funds have been sent, perhaps it would be practical to keep them for a while in case of a problem with one of the parties?

    At the beginning, we thought that keeping resolved dispute cases in an agent's profile might be a privacy issue. However, since we received many requests, we've updated the permissions for agents to view their old resolved contracts. Now agents will be able to see their contracts after they have been resolved.


    -Perhaps a page/history for the agents, so that they can be trusted in disputes?

    - Agent reputation page
    There was a problem with rendering the reputation page for agents, but everything should work fine now.
    Here is how the agent reputation page looks like - Agent Reputation Page
    Here is how a regular user reputation page looks like - User Reputation Page

    We are planning to expand the analytics for the agent reputation page to make it easier for contract parties to choose the right agent. We need more people using Zenland to gather the data.




    Another question: is there an appeal system for the agent's decisions?
    Or is his decision final and absolute?

    Agent's decision is final. Once the money is sent from the contract, the case is closed. There is no appeal system as for now, but we currently have two options:

    First, if a custom agent is bribed: We are launching custom agent features on Bitcointalk because here we have a community. If the buyer/seller believes that the contract was resolved unfairly, they can open a scam thread here on the forum, and we will double-check everything from our side and disable the agent if necessary.

    The second option is the Zenland Forum, where custom agents will be submitting difficult cases to solve. As a community, we can help find the right consensus in more complex cases. These cases can be used as a precedent by other custom agents to help solve cases more efficiently in the future.

    Also, the smart contract is build in a way that once the agent is invited into the contract, only agent can send money out of the contract. Buyer and seller loses rights to release the money.



    • The buyer protection time countdown is stuck at 1 days, 0 hours, 0 minutes in the UI even if it is enforced at the contract level.

    In Contract Details, the buyer protection time is static to show the counterparty all the contract details before approving it. It's very important to read the draft contract before approving it.


    • After the buyer protection time is elapsed, the seller can call release() and take 100% of the buyer's money and there is nothing the buyer can do about it.

    Yes, we designed it so the buyer will not 'burn the money out of spite by never releasing it', as Satoshi once said here Bitcointalk Thread. If the buyer is not satisfied with the delivery, instead of freezing the money, they can always dispute the contract and stop the buyer protection time.


    Suggestion: Be more consistent with the wording for both parties. I personally still don't like the words Contractee and Contractor as a non-native english speaker. Multiple times I caught myself having to think more than I should to avoid mistaking who's who. "Contractee = buyer = sent the USDC" and "Contractor = seller = sent the fake SHIBA".
    • I would prefer if the contractee/contractor names would be ditched and the contract creator could choose if he's the buyer or seller.
    • Hovering the “Seller’s percentage”, “Buyer’s Percentage” or "Agent’s Percentage” information icon on the Splitting Money card shows up a tooltip that blocks the input until the mouse leaves the area. It took me a couple seconds to understand why I couldn’t write on the input.
    • The reputation page was down at the time of my review. Error “Cannot read properties of null (reading 'toLowerCase')” on line 74 of Profile.tsx: params.id.toLowerCase() !== auth.whoAmI.nickname.toLowerCase())
    • After the dispute was concluded, I was sent directly to the Contracts page and an error message popped up with the text “Not found”. It would be better to show the final outcome and the previously disputed contracts on my list.

    Thank you, TryNinja, for your thorough review. We need more testers like you. The incorrect positioning of Seller/Buyer/Agent fields is fixed. New tooltips for the agent page are added. The TypeError on the nickname check is also fixed. Agents can now see their old contracts.

    - I personally find buyer/seller term easier than contractor and contractee.
    use a conventional title for the disputed parties like buyer/seller and not contractor/contractee

    I have personally changed the terms in the chat and in most notifications from Contractee to Buyer and Contractor to Seller. The only place these labels are left is on the contract creation page.

    - Quote option in chat
    - Written chat in text box should stay if you by mistake reload the web page.
    Last question: I haven't found a way of adding 2FA, is this planned for the future?
    • Contract code looks good and secure but lacks comments and some gas optimizations can be done to reduce the gas costs for users (buyer, seller, agent) eg: changing some require statements to custom error and other best practices like using constants instead of magic numbers.
    make provision for being precise when asking any party a question, like a button where you can choose to either ask the buyer or the seller specific questions in the chat and the indications of who the question is meant for.

    Thank you for your contributions. I'm adding them to our To-Do list.